Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load wp_count_posts once and check it before accessing values #63

Merged
merged 1 commit into from
Mar 28, 2024
Merged

load wp_count_posts once and check it before accessing values #63

merged 1 commit into from
Mar 28, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

PHP Notice: Undefined property: stdClass::$publish in /.../newfold-labs/wp-module-data/includes/Listeners/Commerce.php on line 64

https://jira.newfold.com/browse/PRESS1-372

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpscholar wpscholar merged commit 41dca1d into main Mar 28, 2024
8 checks passed
@wpscholar wpscholar deleted the fix/php-notice-undefined-property-publish branch March 28, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@mamatharao05 mamatharao05 Awaiting requested review from mamatharao05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar